Comparing 9aab2d4...14b3336 · canopen-python/canopen · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: canopen-python/canopen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9aab2d4
Choose a base ref
...
head repository: canopen-python/canopen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14b3336
Choose a head ref
  • 4 commits
  • 8 files changed
  • 4 contributors

Commits on Jun 24, 2026

  1. nmt: Fix NmtSlave on a node without a heartbeat producer time. (#672)

    The NMT state transition from INITIALISING to PRE-OPERATIONAL causes
    the heartbeat to start automatically if the parameter is non-zero in
    object 0x1017:00.  This check however raises an exception if the
    object does not even exist.
    
    Cover this state in tests and explicitly ignore a KeyError when asking
    for the object.
    acolomb authored Jun 24, 2026
    Configuration menu
    Copy the full SHA
    ea0efa4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2026

  1. eds: Fix signed integer limit parsing for all bit widths, log errors (#…

    …658)
    
    * eds: fix LowLimit/HighLimit parsing for all signed integer types
    
    - Reimplement _calc_bit_length() (only handled INTEGER8/16/32/64)
      using the same structure types used in ODVariable.
    - Log a warning instead of silently ignoring invalid limit values
    - Add EDS test entries in sample.eds for INTEGER24/40/48/56 with
      hex-encoded negative limits
    - Extend test_record_with_limits and add test_invalid_limit_logs_warning
    
    * Enhance test coverage for _revert_variable() branches (without default_raw).
    
    * Renamed _convert_variable → _decode_from_eds and _revert_variable → _encode_to_eds
    
    Co-authored-by: André Colomb <src@andre.colomb.de>
    Co-authored-by: Frieder Schüler <frieder.schueler@bizerba.com>
    3 people authored Jun 27, 2026
    Configuration menu
    Copy the full SHA
    2a4544a View commit details
    Browse the repository at this point in the history
  2. eds: Support custom_options for unknown EDS fields (#653)

    When importing an EDS/DCF file, any key that is not part of the CiA 306
    standard field set is now collected into a custom_options dict on the object.
    This allows applications to round-trip vendor-specific metadata without
    losing it.
    
    * Use getattr/setattr instead of __dict__ access for array entry attributes.
    
    Co-authored-by: FedericoSpada <FedericoSpada@users.noreply.github.com>
    Co-authored-by: André Colomb <src@andre.colomb.de>
    3 people authored Jun 27, 2026
    Configuration menu
    Copy the full SHA
    3b57fed View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2026

  1. emcy: Catch callback exceptions and expand test coverage (#659)

    - Fix bug where an exception in one EMCY callback would abort all
      subsequent callbacks; now logs the exception and continues
    - Add test for callback exception handling (verifies fix)
    - Add tests for EmcyConsumer initialization, multiple callback order,
      error reset variants, wait timeout edge cases, concurrent errors
    - Add tests for EmcyError initialization types and str representation
    - Add tests for EmcyProducer initialization, send/reset edge cases
    - Add TestEmcyIntegration class using network.subscribe() for
      producer-consumer roundtrip tests
    - Remove superfluous inline comments per reviewer feedback (acolomb)
    - Convert leading comment to docstring in test_emcy_consumer_on_emcy
    
    Addresses review feedback from PR #604 by yuvraj-kolkar17.
    
    * Factor out mock_rx_thread().
    
    Simplify by extracting Thread creation and starting, and joining to
    one central helper function, including the emcy_received condition
    lock to avoid race conditions.
    
    Co-authored-by: André Colomb <src@andre.colomb.de>
    Co-authored-by: Frieder Schüler <frieder.schueler@bizerba.com>
    3 people authored Jun 28, 2026
    Configuration menu
    Copy the full SHA
    14b3336 View commit details
    Browse the repository at this point in the history
Loading