{{ message }}
Improve compatibility with PHP 7.4#161
Merged
Merged
Conversation
CakePHP 3.8.2 introduced a change to TestCase.php which replaced the use of curly braces for array access with square brackets, which is now required by PHP 7.4.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes ACL more compatible with PHP 7.4 by removing usage of syntax that has been deprecated in PHP 7.4, namely the usage of curly braces for array element access. This change includes changing the minimum version of CakePHP to 3.8.2 in order to incorporate a similar change that was made to CakePHP's TestCase.php class.