{{ message }}
Repository navigation
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
|
The getCommandExecuteDetail function was hardcoding a 80-character truncation on the SQL statement, appending '...' for longer statements. This made SDL (Schema Definition Language) changes unreadable in the changelog detail page since SDL statements are typically very long. Removed the truncation entirely; CSS (break-words, overflow: auto) handles long text naturally.
kate1128
force-pushed
the
fix/sdl-statement-truncation
branch
from
September 2, 2026 12:34
0ac582a to
f919abf
Compare
Collaborator
zchpeter
added a commit
that referenced
this pull request
Sep 18, 2026
The log cuts every executed statement to 80 characters inside the model, so nothing downstream can show or copy the rest. #21276 removes the cut but keeps the whitespace collapse above it, which turns a wide CREATE TABLE into one run-on line inside a 200px box. The doc lands on one rule: the model returns both forms of an entry, the line the row shows and the text that line stands for, and destroys neither. Truncation becomes CSS on the line; copy and unfold act on the text. A statement row folds by default and unfolds in place with its original formatting; an error row stays open, because an error is why the log was opened. Implementation follows in a separate PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove 80-char truncation of executed statement in changelog viewer
Fixes #21318
Problem:
When using SDL (Schema Definition Language), the executed statement in the changelog detail page is truncated to 80 characters with "..." appended.
SDL statements are typically very long (e.g., full CREATE TABLE), making them unreadable.
Root Cause:
getCommandExecuteDetail in frontend/src/components/task-run-log/model.ts hardcodes a 80-character truncation.
Fix:
Removed the truncation entirely. The statement is now rendered in full, and CSS (break-words, overflow: auto) handles long text naturally.
Verification:
Screenshots
After fix - changelog detail page showing the full statement:
