fix(pg): emit schema file for multi-file SDL by rebelice · Pull Request #20530 · bytebase/bytebase · GitHub
Skip to content

fix(pg): emit schema file for multi-file SDL - #20530

Merged
rebelice merged 1 commit into
mainfrom
codex/pg-multi-file-schema-sdl
Jun 5, 2026
Merged

rebelice merged 1 commit into
mainfrom
codex/pg-multi-file-schema-sdl

Conversation

@rebelice

@rebelice rebelice commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • emit schemas/<schema>/schema.sql for PostgreSQL multi-file SDL output
  • include schema creation and schema comments in the schema file
  • add regression coverage that combined multi-file SDL loads through the SDL diff path

Testing

  • gofmt -w backend/plugin/schema/pg/get_database_definition.go backend/plugin/schema/pg/get_database_definition_sdl_test.go
  • go test -v -count=1 ./backend/plugin/schema/pg -run '^(TestGetMultiFileDatabaseDefinition|TestGetDatabaseDefinitionSDLFormat|TestDiffSDLMigration)'\n- git diff --check\n\n## Notes\n- golangci-lint run --allow-parallel-runners and golangci-lint run --fix --allow-parallel-runners could not complete in this worktree because the local filesystem has about 438MiB free; failures were Go cache/typecheck and no space left on device, not a reported issue in this diff.\n- Full server build was not run for the same disk-space reason.

@rebelice
rebelice requested a review from a team as a code owner June 5, 2026 08:17
@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2026

Copy link
Copy Markdown

@rebelice
rebelice enabled auto-merge (squash) June 5, 2026 08:21
@rebelice
rebelice merged commit 579d8e0 into main Jun 5, 2026
16 checks passed
@rebelice
rebelice deleted the codex/pg-multi-file-schema-sdl branch June 5, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants