{{ message }}
Repository navigation
Conversation
vsai12
requested review from
a team,
RainbowDashy,
d-bytebase and
ecmadao
as code owners
October 29, 2025 10:18
h3n4l
reviewed
Oct 30, 2025
vsai12
marked this pull request as draft
October 30, 2025 02:28
Comment on lines
+30
to
+32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Implements core audit log sequencer (PR # 2) with guaranteed gap-free sequence numbers (1, 2, 3...) for reliable log aggregation and integrity monitoring.
Key Features
Implementation Details
EnsureUniqueBytebaseIDwith collision retry (up to 5 attempts)common.Errorwith proper codes (Invalid, Internal, SizeExceeded)Files Changed
backend/common/audit/: config.go, logger.go, service.go, validation.go, instance.go (refactored)backend/store/audit_log.go: Added EnsureUniqueBytebaseID methodbackend/migrator/migration/3.9/0011##audit_log_unique_bytebase_id.sql: UNIQUE indexDependencies
Requires PR #17897 (proto fields + Bytebase ID generation)