Add Customers resouce to Rubygem by chrismaddern · Pull Request #13 · button/button-client-ruby · GitHub
Skip to content

Add Customers resouce to Rubygem#13

Merged
chrismaddern merged 5 commits into
masterfrom
chris/customers_api
Mar 29, 2017
Merged

Add Customers resouce to Rubygem#13
chrismaddern merged 5 commits into
masterfrom
chris/customers_api

Conversation

@chrismaddern

Copy link
Copy Markdown
Contributor

No description provided.

@griffinmyers griffinmyers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This is awesome @chrismaddern!! Thanks for contributing : )

Let's call this 2.1.0 instead. When you make that change, we can merge. I'll then cut a release on Github and publish to rubygems.

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to follow semver for this project. Could we make this v2.1.0 instead? This introduces new functionality in a backwards-compatible way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @griffinmyers!

Will update now!

@chrismaddern

Copy link
Copy Markdown
Contributor Author

@griffinmyers griffinmyers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@chrismaddern chrismaddern merged commit 009ac26 into master Mar 29, 2017
@chrismaddern chrismaddern deleted the chris/customers_api branch March 29, 2017 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants