{{ message }}
This repository was archived by the owner on Aug 24, 2026. It is now read-only.
Fix span detail format - #79
Merged
Merged
Conversation
Format spans in format expected by Test Engine.
scadu
marked this pull request as ready for review
November 21, 2025 10:57
Align type with Test Engine, simplify implementation. Make pylint happy
scadu
force-pushed
the
fix/span_details_missing
branch
from
November 25, 2025 08:41
d286f98 to
0ea0fa4
Compare
nprizal
approved these changes
Nov 25, 2025
nprizal
left a comment
nprizal
left a comment
Contributor
There was a problem hiding this comment.
Hi @scadu, thanks for opening the PR. It looks great! I appreciate you adding the codedoc around the expected data structure for span details.
We’re planning to implement validation to prevent the collector from sending invalid span data but we’ll open a separate PR for that.
scadu
changed the title
nprizal
reviewed
Nov 26, 2025
nprizal
reviewed
Nov 26, 2025
nprizal
suggested changes
Nov 26, 2025
nprizal
left a comment
nprizal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the validation 💚 . I think we want the detail to be required for sql, http, and annotation. Is that right @gchan @malclocke?
Contributor
Co-authored-by: Naufan P. Rizal <np.rizal@icloud.com>
Contributor
Author
Merged
nprizal
changed the title
pda
pushed a commit
to buildkite/bktest
that referenced
this pull request
Aug 24, 2026
…span_details_missing Fix span detail format for Test Engine UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format spans in format expected by Test Engine.
Since
detailstype is changed fromstringtodict, this could be a breaking change, even though span details previously wouldn't work due to the type mismatch between collector and Test Engine.