[5.2] Bug 1917423: undo params mess from bug 1898882 by justdave · Pull Request #214 · bugzilla/bugzilla · GitHub
Skip to content

[5.2] Bug 1917423: undo params mess from bug 1898882#214

Open
justdave wants to merge 1 commit into
bugzilla:5.2from
justdave:bug1917423-5.2
Open

[5.2] Bug 1917423: undo params mess from bug 1898882#214
justdave wants to merge 1 commit into
bugzilla:5.2from
justdave:bug1917423-5.2

Conversation

@justdave

@justdave justdave commented Jun 20, 2026

Copy link
Copy Markdown
Member

Details

This PR removes the need to store the current database charset in the params file, instead detecting it only at runtime and saving it in memory during the operation of checksetup.pl. The params are instead remapped to the detected value if appropriate.

Additional info

Test Plan

  1. Created a new database from scratch with a clean checkout of this branch, and went through the installation procedure. Installation completed without error, the complaint about the data directory missing is gone.
  2. Manually tweaked some table charsets to trigger the charset conversion code, ran checksetup.pl again, and ensured that charset conversion happened correctly.

@justdave justdave requested a review from dylanwh June 20, 2026 08:04
@justdave justdave changed the title [5.2] Bug 1917523: undo params mess from bug 1898882 [5.2] Bug 1917423: undo params mess from bug 1898882 Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant