{{ message }}
support opts.package in non-relative lookups#152
Merged
Conversation
ljharb
approved these changes
Apr 4, 2018
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
Thanks, this seems like a straightforward bugfix that only impacts when opts.package is provided.
ljharb
added a commit
that referenced
this pull request
Apr 7, 2018
- [New] `resolve.sync`: add `opts.pathFilter` (#146) - [Fix] Make loadAsFileSync() work the same as async loadAsFile() (#146) - [Fix] support `opts.package` in non-relative lookups (#152) - [Docs] fix default “isFile” implementations - [Docs] fix options formatting - [Refactor] cache default isFile functions at module level - [Refactor] use "basedir" instead of "y", because meaningful variable names - [Tests] add some tests for a non-directory basedir (#154) - [Tests] work around npm SSL issue - [Tests] add some tests for browser field - [Tests] add node 8 and 9 to appveyor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the non-relative lookup here was missed when adding the
opts.packagefeature (which I would like to utilize).