{{ message }}
IE 11 compatibility when Symbol is polyfilled#47
Merged
goto-bus-stop merged 3 commits intoApr 30, 2020
Conversation
wbinnssmith
force-pushed
the
wbinnssmith/corejs
branch
from
0fa099e to
4068972
Compare
Contributor
Author
ljharb
approved these changes
Apr 29, 2020
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
Seems like a clean semver-patch that makes these checks go from "not particularly robust" to "as unbreakable as i know to be possible" :-)
i'm obviously a bit biased, so this should get more eyes before landing.
Member
lukechilds
approved these changes
Apr 30, 2020
goto-bus-stop
approved these changes
Apr 30, 2020
goto-bus-stop
left a comment
goto-bus-stop
left a comment
Member
There was a problem hiding this comment.
Saucelabs tests don't run on pull requests—pushed a branch to trigger a full run here: https://travis-ci.org/github/browserify/node-util/jobs/681393138
Will merge once that comes up green. Thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #40.
Currently, with a Symbol polyfill present in IE 11, requiring
util/typesthrows (see #40 for more detail). WithSymbolandSymbol.toStringTagavailable, IE 11 then attempts to use it on the Uint8Array prototype, where it does not exist.This:
is-typed-arrayandwhich-typed-arrayto determine if values are typed arrays and which type they are.Ideally this is published in a patch release or https://github.com/browserify/commonjs-assert is updated to use it, as folks seem to run into this through their use of
assert(though it's certainly possible to useutil/typesdirectly).cc @mischnic @devongovett @padmaia @stacylondon
Test Plan: Ran both sets of tests (with and without polyfills) in IE 11 with success.