update Node.js versions used in Travis CI checks by striezel · Pull Request #2008 · browserify/browserify · GitHub
Skip to content

update Node.js versions used in Travis CI checks - #2008

Open
striezel wants to merge 4 commits into
browserify:masterfrom
striezel-stash:update-travis-ci
Open

striezel wants to merge 4 commits into
browserify:masterfrom
striezel-stash:update-travis-ci

Conversation

@striezel

@striezel striezel commented May 9, 2021

Copy link
Copy Markdown

Node.js versions below 10.x are not maintained anymore, so it is probably best to use some newer, still maintained versions.
For release cyles of Node.js see the official site: https://nodejs.org/en/about/releases/.

striezel added 3 commits May 9, 2021 13:24
Node.js versions below 10.x are not maintained anymore, so it
is probably best to use some newer, still maintained versions.
For release cyles of Node.js see the official site:
<https://nodejs.org/en/about/releases/>.
Node.js versions below 10.x are not maintained anymore, so it
is probably best to use some newer, still maintained versions.
AppVeyor cannot find a matching package to install for Node 16,
so do not use it on AppVeyor. For an example of that problem see
<https://ci.appveyor.com/project/browserify/browserify/builds/39074493/job/f56gjo1d8f1odghj>
@striezel

striezel commented May 9, 2021

Copy link
Copy Markdown
Author

Comment thread .travis.yml
@striezel

Copy link
Copy Markdown
Author

@ljharb: Checks with old versions of Node.js fail on Travis and AppVeyor, but that happened on the current commit of the master branch (0ec6e80), too. So I guess that is how it is supposed to be.

@striezel

striezel commented May 18, 2021 •

Copy link
Copy Markdown
Author

Since there has been no activity here for almost a week: Is there anything else blocking this PR? Any more change requests? If so, please let me know.
Thanks. :)

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@striezel

striezel commented Jul 3, 2021

Copy link
Copy Markdown
Author

@ljharb:

LGTM

Good.

Since this pull request has been approved one and a half month ago but it has not been merged yet: Is there anything else to do? If not, can someone merge it please?
Thanks. :)

@ljharb

ljharb commented Jul 3, 2021

Copy link
Copy Markdown
Member

@striezel tests are failing on master in node < 4, and altho i reviewed this PR, i don't typically maintain browserify, so it needs to wait for the maintainers.

@ljharb
ljharb requested a review from goto-bus-stop July 3, 2021 21:25
@striezel

striezel commented May 6, 2022

Copy link
Copy Markdown
Author

@goto-bus-stop or who is currently maintaining browserify: Is there a chance to get a review on the changes?

Is this still relevant after almost a year now?

@mikixing

This comment was marked as spam.

@legobeat

legobeat commented Sep 10, 2023 •

Copy link
Copy Markdown

@ljharb @goto-bus-stop @feross Would dropping 0.10 and 0.12 be up for reconsideration alongside #2070 ?

Split that out to #2071, which does not overlap with this PR.

@ljharb

ljharb commented Sep 10, 2023

Copy link
Copy Markdown
Member

Nope, we will continue to support them.

@striezel

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants