{{ message }}
Repository navigation
Conversation
define('punycode', function() {
return punycode;
});
which is portable when using requireJS.
goto-bus-stop
left a comment
Member
There was a problem hiding this comment.
Node.js uses punycode 2.0.0 and it'd be best if we're in sync with them.
However punycode 2+ use ES6 features which are only supported in recent browsers, ideally browserify's node core shims work way back in old browsers too…
punycode 2.0.0 is actually identical to 1.3.2 except for the ES6 syntax. The best thing to do here might be to have a new punycode-browserify package that is punycode 2.0.0 compiled to ES5.
Author
Author
|
Besides, Could you help to do it? |
Member
|
Yes I think I worked on one a few months ago. I'll see if I can dig it up on the weekend. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use the latest punycode, since punycode(1.3.2) export with:
define('punycode', function() { return punycode; });which isn't portable when using requireJS.