{{ message }}
Repository navigation
Conversation
Claven07
marked this pull request as ready for review
October 16, 2026 21:26
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Click Fix with cubic on a comment, or reply @cubic-dev-ai fix this, and cubic writes the fix.
View guided diff | Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR proposes an observational approach related to issue #6068: record restricted form-control state changes observed around
evaluate, while preserving the original JavaScript result.It overlaps with PR #6106, which adds an inline-wrapper warning. This PR explores a complementary CDP isolated-world observer.
Approach
evaluateresult and schema-backed structured-output behavior.Important limitations
evaluateis correlation, not proof that the evaluated code caused it or that a policy violation occurred. A legitimate synchronous page handler can also enable a control.Validation
.venv\Scripts\python.exe -m pytest -q tests/ci/test_evaluate_control_state_observation.py tests/ci/test_agent_history_policy.py tests/ci/test_sandbox_structured_output.py tests/ci/test_cdp_timeout.py— 63 passed in 11.83s, including the real-browser/CDP cancellation regression.git diff --checkpassed.ed5b4ad505d5368badd33849fc00856483ce0ac8: test passed; lint passed. The “Evaluate PR” workflow was skipped.Maintainer feedback requested
Would the isolated-world observer provide useful complementary coverage to #6106, or would you prefer this contribution to focus on a smaller independent test or history-integrity change?
This PR does not claim to fully fix or close #6068.