{{ message }}
fix: preserve explicit empty accessibility names in DOMInteractedElement#5049
Open
neelabhshukla018 wants to merge 1 commit into
Open
fix: preserve explicit empty accessibility names in DOMInteractedElement#5049neelabhshukla018 wants to merge 1 commit into
neelabhshukla018 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR fixes an edge case in
DOMInteractedElement.load_from_enhanced_dom_treewhere an explicit empty accessibility name ("") is treated the same asNonedue to an implicit truthiness check.Changes
Replaced:
with:
This preserves intentionally empty accessibility names while still correctly handling
None.Related Issue
Fixes #5041.
Summary by cubic
Preserves explicit empty accessibility names ("") when building
DOMInteractedElementfrom an enhanced DOM tree by checking forNoneinstead of truthiness. This prevents deliberate empty names from being overwritten asNone.Written for commit a27bd87. Summary will update on new commits.