{{ message }}
fix(agent): correct step_interval calculation#4699
Open
vincent067 wants to merge 2 commits intobrowser-use:mainfrom
Open
fix(agent): correct step_interval calculation#4699vincent067 wants to merge 2 commits intobrowser-use:mainfrom
vincent067 wants to merge 2 commits intobrowser-use:mainfrom
Conversation
The step_interval was incorrectly computing the duration of the previous step instead of the idle time gap between steps. Before: step_interval = previous_end_time - previous_start_time After: step_interval = self.step_start_time - previous_end_time Fixes browser-use#4484
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Fixes #4484
Problem
The step_interval in StepMetadata was incorrectly computing the duration of the previous step instead of the idle time gap between steps.
Changes
Impact
Any monitoring or telemetry relying on step_interval now receives correct idle time data between steps.
Thanks to @warren618 for the clear bug report! 🙏
Summary by cubic
Corrected the step_interval calculation to measure idle time between steps instead of the previous step’s duration, ensuring accurate telemetry for step gaps.
StepMetadata.step_intervalnow usesself.step_start_time - previous_end_time, fixing prior misreporting.Written for commit e84d015. Summary will update on new commits.