{{ message }}
Repository navigation
fix: publish sophie_assistant.js (fixes #197) - #198
Open
shivasymbl wants to merge 1 commit into
Open
shivasymbl wants to merge 1 commit into
shivasymbl wants to merge 1 commit into
Conversation
server.js imports ./sophie_assistant.js, but package.json "files" does not list it, so the 4.0.0 npm package fails at startup with ERR_MODULE_NOT_FOUND. Add it, plus a test that every local module a published file imports is itself published. Fixes brightdata#197 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.jsimports./sophie_assistant.js, butpackage.jsonfilesdoesn't list it. So@brightdata/mcp@4.0.0from npm crashes on startup:Repro:
npm i -g @brightdata/mcp@4.0.0 && API_TOKEN=x node "$(npm root -g)/@brightdata/mcp/server.js"Change
sophie_assistant.jstofiles.test/package-files.test.js. It fails if any published.jsfile imports a local module that isn't published, which catches this class of bug for the next new module.Tests
server.js imports ./sophie_assistant.js, not in package.json files) and passes after it.npm test: 121/121 pass.npm pack --dry-runnow includessophie_assistant.js.Fixes #197
🤖 Generated with Claude Code