{{ message }}
fix: include parent span IDs in daemon merge writes - #52
Open
max-braintrust wants to merge 1 commit into
Open
Conversation
max-braintrust
force-pushed
the
fix/codex-parent-identity
branch
from
September 4, 2026 23:46
12b9682 to
a7d40f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue
Merge writes from the plugins did not include parent ids. This was a problem if no successful insert write proceeded the merge write for a particular span, because the span would be attached to the trace without a parent. Spans without parents automatically get is_root=true, so this can lead to a situation where a trace has multiple spans marked as the root.
Solution
Include the correct root_span_id and parent span IDs in every merge write, using the same deterministic hierarchy used by the corresponding insert. This allows a merge to preserve the span’s hierarchy even when the initial insert was not persisted, without requiring a sink-side identity cache.
Add regression coverage to verify that: