{{ message }}
Forwarding shares to peers#257
Merged
Merged
Conversation
Sansh2356
force-pushed
the
10-3-2025-Forwarding-shares-to-peers
branch
from
7951aeb to
d5afeb3
Compare
mcelrath
requested changes
Oct 9, 2025
mcelrath
left a comment
mcelrath
left a comment
Collaborator
There was a problem hiding this comment.
I like this design a lot better, I think it's a lot more modular and logical.
I'd like you to go through the SwarmHandler and put in real data everywhere you can. Wherever you have to use fake data, add a FIXME or TODO marker so we can discuss how to make it not-fake. We can put those things in a new PR.
For example the miner pubkey is going to have to be a config option or stored in ~/.braidpool, and we can discuss how we want to do that. We might use the libp2p pubkey here and then we have to figure out how to sign with it.
Other things like timestamps, should be "now".
Sansh2356
force-pushed
the
10-3-2025-Forwarding-shares-to-peers
branch
from
d5afeb3 to
7d6763b
Compare
Sansh2356
force-pushed
the
10-3-2025-Forwarding-shares-to-peers
branch
from
7d6763b to
d71b915
Compare
Changing the event handling and removing shared swarm Adding swarm handler as interface between swarm and stratum service Updating params in no_version_rolling_submit test Removing cpuminer compatible conditions Replacing temp data with actual data
Sansh2356
force-pushed
the
10-3-2025-Forwarding-shares-to-peers
branch
from
d71b915 to
71e2cca
Compare
mcelrath
pushed a commit
to mcelrath/braidpool
that referenced
this pull request
Nov 18, 2025
…dpool#257) Changing the event handling and removing shared swarm Adding swarm handler as interface between swarm and stratum service Updating params in no_version_rolling_submit test Removing cpuminer compatible conditions Replacing temp data with actual data
jevinjojo
pushed a commit
to jevinjojo/braidpool
that referenced
this pull request
Dec 5, 2025
…dpool#257) Changing the event handling and removing shared swarm Adding swarm handler as interface between swarm and stratum service Updating params in no_version_rolling_submit test Removing cpuminer compatible conditions Replacing temp data with actual data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwarmHandler.