{{ message }}
Add json tests for braid::extend()#227
Merged
Merged
Conversation
Signed-off-by: Aritra Majumder <aritramajumder8438@gmail.com>
Signed-off-by: Aritra Majumder <aritramajumder8438@gmail.com>
Aritra8438
requested review from
Sansh2356 and
mcelrath
and removed request for
mcelrath
Sansh2356
approved these changes
Jul 17, 2025
Sansh2356
left a comment
Sansh2356
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Updating the existing extend function and adding cohort_tips attribute along with the merging of extend functions for the simulation generated test files from our test directory is good and was required as conveyed by @mcelrath .
mcelrath
pushed a commit
to mcelrath/braidpool
that referenced
this pull request
Nov 18, 2025
* Add `json` tests for braid Signed-off-by: Aritra Majumder <aritramajumder8438@gmail.com> * fix the `extend()` function Signed-off-by: Aritra Majumder <aritramajumder8438@gmail.com> --------- Signed-off-by: Aritra Majumder <aritramajumder8438@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
jsonfiles as tests for extend function.