{{ message }}
Conversation
mcelrath
reviewed
Jul 9, 2025
mcelrath
left a comment
mcelrath
left a comment
Collaborator
There was a problem hiding this comment.
This looks good!
(Still need to test it)
mcelrath
requested changes
Jul 11, 2025
mcelrath
left a comment
mcelrath
left a comment
Collaborator
There was a problem hiding this comment.
Tested this with curl, seems fine. We need data!
Just fix the logic in Braid::extend() otherwise this looks good.
Removing commented fields from test.rs cargo-fmt
mcelrath
approved these changes
Jul 12, 2025
Sansh2356
changed the title
RPC implementation according to the new structure we had decided RPC implementation according to the new structure we had decided
mcelrath
pushed a commit
to mcelrath/braidpool
that referenced
this pull request
Nov 18, 2025
…ure we had decided (braidpool#224) * feat:rpc addition along with refactoring of cli * Updating the config.rs with rpc_config * modifying the braid initialization && reverting extend Removing commented fields from test.rs cargo-fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpcmethods accessible both viaclias well as from frontend viacurloraxios.