{{ message }}
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the bead_sync protocol to support bead retrieval and synchronization between nodes. Key changes include:
- Exposing additional types in test_utils for broader usage.
- Adding bead_sync event handling in the main event loop.
- Integrating a new request‐response protocol for bead, tips, and genesis data in both the behaviour and bead modules.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
Comments suppressed due to low confidence (1)
node/src/bead/tests.rs:181
- P2P_Address and ServiceFlags are used without being imported. Add the necessary import statements (e.g., 'use bitcoin::p2p::address::Address as P2P_Address;' and 'use bitcoin::p2p::ServiceFlags;') to avoid compilation errors.
let _address = P2P_Address::new(&test_sock_add.clone(), ServiceFlags::NONE);
Sansh2356
reviewed
Jun 18, 2025
Sansh2356
reviewed
Jun 18, 2025
mcelrath
approved these changes
Jun 20, 2025
mcelrath
left a comment
mcelrath
left a comment
Collaborator
There was a problem hiding this comment.
This looks very good, merging.
We need to prioritize performing a functional test with actual bead data as soon as we are able.
mcelrath
pushed a commit
to mcelrath/braidpool
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request responsefunctionality for the purpose ofIBD(inital beed download) along with that additionally for P2P queries .