feat:Kademlia support , Braidpool Configuration set up and DNS service . by Sansh2356 · Pull Request #206 · braidpool/braidpool · GitHub
Skip to content

feat:Kademlia support , Braidpool Configuration set up and DNS service . #206

Merged
mcelrath merged 5 commits into
devfrom
feat/configuration_set_up
Jun 18, 2025
Merged

feat:Kademlia support , Braidpool Configuration set up and DNS service . #206
mcelrath merged 5 commits into
devfrom
feat/configuration_set_up

Conversation

@Sansh2356

Copy link
Copy Markdown
Contributor

Addresses #186 , #177 and #184 #178.

@Sansh2356 Sansh2356 requested a review from mcelrath June 6, 2025 13:54

@mcelrath mcelrath left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boot node is reporting to peers a localhost address:

[2025-06-06T14:23:23Z INFO  node] received addr /ip4/74.50.123.158/udp/8888/quic-v1 through identify
[2025-06-06T14:23:23Z INFO  node] received addr /ip4/127.0.0.1/udp/8888/quic-v1 through identify

Make sure nodes never report local or unroutable IPs to peers at all. The boot node is reporting two multiaddrs for itself, one of which is unusable.

Comment thread node/src/main.rs
@Sansh2356 Sansh2356 requested a review from a team June 7, 2025 01:05
@mcelrath

Copy link
Copy Markdown
Collaborator

Comment thread node/Cargo.toml Outdated
Sansh2356 and others added 2 commits June 18, 2025 22:33
Co-authored-by: Aritra <aritramajumder8438@gmail.com>
@Sansh2356 Sansh2356 requested review from Aritra8438 and mcelrath June 18, 2025 17:27

@mcelrath mcelrath left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, looks good!

@mcelrath mcelrath merged commit 4bca78f into dev Jun 18, 2025
11 checks passed
@mcelrath mcelrath deleted the feat/configuration_set_up branch June 18, 2025 18:15
@Sansh2356 Sansh2356 mentioned this pull request Jun 22, 2025
37 tasks
mcelrath pushed a commit to mcelrath/braidpool that referenced this pull request Nov 18, 2025
…e . (braidpool#206)

* braidpool configuration file for binary setup

* default configuration file

* Adding kademlia support & boot nodes for peer discovery and DNS NS

* Update node/Cargo.toml

Co-authored-by: Aritra <aritramajumder8438@gmail.com>

---------

Co-authored-by: Aritra <aritramajumder8438@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants