libp2p bootstrap by ABD-AZE · Pull Request #187 · braidpool/braidpool · GitHub
Skip to content

libp2p bootstrap#187

Merged
mcelrath merged 1 commit into
braidpool:devfrom
ABD-AZE:libp2p_bootstrap_new
May 28, 2025
Merged

libp2p bootstrap#187
mcelrath merged 1 commit into
braidpool:devfrom
ABD-AZE:libp2p_bootstrap_new

Conversation

@ABD-AZE

@ABD-AZE ABD-AZE commented May 28, 2025

Copy link
Copy Markdown

Copilot AI review requested due to automatic review settings May 28, 2025 15:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces libp2p integration to bootstrap network connectivity, updating the self-test script, main node logic, CLI defaults, and Cargo dependencies to support the new libp2p-based connectivity. Key changes include:

  • Updating selftest.sh to use new cargo run parameters and adjust the process termination command.
  • Replacing TCP-based connection handling in node/src/main.rs with libp2p swarm-based dialing and event handling.
  • Modifying CLI documentation and default bind address, and updating Cargo.toml to add the libp2p dependency.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File Description
selftest.sh Updated cargo commands and changed process kill command.
node/src/main.rs Replaced TCP Listener/dialer logic with libp2p swarm implementation.
node/src/cli.rs Updated CLI bind argument documentation and default value.
node/Cargo.toml Updated tokio features and added libp2p dependency.

Comment thread selftest.sh
Comment on lines +5 to +13

Copilot AI May 28, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that using 'killall node' will not unintentionally terminate other unrelated processes named 'node'. Consider using a more specific process identifier or pattern to target only the intended process.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rename this to braidpoold or braidpool-node because node is nodejs on many systems. We'll do this in a future PR.

Comment thread node/src/main.rs
Comment thread node/src/cli.rs Outdated
@ABD-AZE ABD-AZE requested a review from mcelrath May 28, 2025 15:12
@ABD-AZE ABD-AZE force-pushed the libp2p_bootstrap_new branch from da3914b to 962c7e7 Compare May 28, 2025 17:45
@ABD-AZE ABD-AZE force-pushed the libp2p_bootstrap_new branch from 962c7e7 to 5eb6879 Compare May 28, 2025 18:03
@mcelrath mcelrath merged commit 6bf0e39 into braidpool:dev May 28, 2025
6 checks passed
@mcelrath mcelrath mentioned this pull request May 28, 2025
@Sansh2356 Sansh2356 mentioned this pull request Jun 22, 2025
37 tasks
mcelrath pushed a commit to mcelrath/braidpool that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants