{{ message }}
add useLOST to triangulateSafe - #1517
Merged
Merged
Conversation
Contributor
Contributor
|
Thanks @dllu , it would be great if you could also add a unit test for triangulateSafe with useLOST=True here: |
Contributor
dellaert
approved these changes
Sep 4, 2023
dellaert
left a comment
dellaert
left a comment
Member
There was a problem hiding this comment.
I'm just going to approve and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a way to use the new LOST triangulation in
triangulateSafeby setting theuseLOSTparameter inTriangulationParametersaccordingly.By the way, what version of
clang-formatdo people use? for some reason when I ranclang-format -i gtsam/geometry/triangulation.hit resulted in many changed lines (usingclang-format version 10.0.0-4ubuntu1).