Document from_bits_unchecked unsafety (#200) by niklasf · Pull Request #207 · bitflags/bitflags · GitHub
Skip to content

Document from_bits_unchecked unsafety (#200) - #207

Merged
KodrAus merged 1 commit into
bitflags:masterfrom
niklasf:unsafe-from-bits-unchecked
Jan 28, 2020
Merged

KodrAus merged 1 commit into
bitflags:masterfrom
niklasf:unsafe-from-bits-unchecked

Conversation

@niklasf

@niklasf niklasf commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

Every unsafe method should have documented safety invariants. Here's an attempt for from_bits_unchecked().

@KodrAus KodrAus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niklasf! This looks good to me

@KodrAus
KodrAus merged commit 15e911c into bitflags:master Jan 28, 2020
@SOF3

SOF3 commented Aug 10, 2020

Copy link
Copy Markdown

@KodrAus

KodrAus commented Aug 11, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants