{{ message }}
Added support and info for custom formatters in Firefox#72
Merged
Conversation
danielcompton
left a comment
danielcompton
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks correct but I'll need to test it out locally to confirm.
It might be even better to do feature detection on the hooks themselves, but that could come later.
Comment on lines
+15
to
+18
Collaborator
There was a problem hiding this comment.
(defn ^:dynamic available? []
(or (in-node-context?)
(isAtLeast "CHROMIUM" 47)
(isAtLeast "EDGE" 79) ;; First Edge to use Blink, has Blink 79.
(isAtLeast "FIREFOX" 110)))
Collaborator
Author
There was a problem hiding this comment.
Done that and added Edge to the documentation. I also updated the Firefox version to 111 because the final parsing of custom formatters didn't land yet.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, here are the changes to add support for Firefox. We plan to enable custom formatters in Firefox starting from 110, so I've added that version check.
Please do a quick check and let me know whether the code change is ok.
Unfortunately, I couldn't manage to do re-compilation of the code, so I couldn't properly test it on my side yet.
Sebastian