{{ message }}
[PORT-5641] Update host for Avalara for Communications REST API. (#230)#1
Merged
Merged
Conversation
benfjohnson
pushed a commit
that referenced
this pull request
May 16, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency
benfjohnson
pushed a commit
that referenced
this pull request
May 22, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * fixes for latest sandbox v2 swagger doc
benfjohnson
pushed a commit
that referenced
this pull request
May 23, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * Better README instructions, docker support for easy Windows development and simpler build
benfjohnson
pushed a commit
that referenced
this pull request
May 24, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * Better README instructions, docker support for easy Windows development and simpler build * Minor updates to docker (#2) * make docker easier to use for everyday development Strip out adding the repo to the image and rather mount the code to a volume in the container. Pass CMD in on container invocating rather than as a startup command for the image so that if the dev is having issues with container start up, they can debug it with a different start up command. separate docker build and run so that it is not rebuilt every time a container is started * install dependencies on host via docker container Before we were installing dependencies on image but then overwriting them by mounting the repo over it on the container. Now we are building the image without node_modules. Then on the initial container invocation, we run `npm i` which installs deps on the mounted volume (binding them to the host machine) so that they may be persisted for future containers * readme update
benfjohnson
pushed a commit
that referenced
this pull request
May 25, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * fixed bad links to localhost
benfjohnson
pushed a commit
that referenced
this pull request
May 25, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * Updated proxy AWS endpoints
benfjohnson
pushed a commit
that referenced
this pull request
May 30, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * example req, response and curls per Ted's documentation * test fixes
benfjohnson
pushed a commit
that referenced
this pull request
Jun 1, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * DX-347: add (_include) template for models Keep most of the logic here so that it works (out of the box) with whatever lives in _data. This should be coupled with a symlink to dynamic/swagger. * DX-347: script to build models html pages * DX-347: add enums Also prevent adding examples pertaining to properties that have their own models page * DX-347: fix templates for models with [...] in name liquid templates were not rendering as they were, so I had to assign the name in a separate handlebar * DX-347: put finishing touches on model pages change node code to ES6 and use browsify --node now writing models/index.html. Navigation side bar only shows models pertaining to that model. ** see TODOs in commit ** restructuring swagger directory to have a consistent naming convention across all APIs * DX-347: grab product name from SWAGGER_CONFIG * DX-347: fix product name bug * small change to enable object properties to generate their own links in model docs * DX-347: rename swagger files and directory structure Directory structure was messy before. Relevant changes regarding this renaming were made for build script and config file * Property rendering now in seperate include, handle use of allOf in swagger defs, fix for object links
benfjohnson
pushed a commit
that referenced
this pull request
Jun 2, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * DX-347: add (_include) template for models Keep most of the logic here so that it works (out of the box) with whatever lives in _data. This should be coupled with a symlink to dynamic/swagger. * DX-347: script to build models html pages * DX-347: add enums Also prevent adding examples pertaining to properties that have their own models page * DX-347: fix templates for models with [...] in name liquid templates were not rendering as they were, so I had to assign the name in a separate handlebar * DX-347: put finishing touches on model pages change node code to ES6 and use browsify --node now writing models/index.html. Navigation side bar only shows models pertaining to that model. ** see TODOs in commit ** restructuring swagger directory to have a consistent naming convention across all APIs * DX-347: grab product name from SWAGGER_CONFIG * DX-347: fix product name bug * small change to enable object properties to generate their own links in model docs * DX-347: rename swagger files and directory structure Directory structure was messy before. Relevant changes regarding this renaming were made for build script and config file * Property rendering now in seperate include, handle use of allOf in swagger defs, fix for object links * working definition builder * swagger file fixes * working model pages * minor naming change
benfjohnson
pushed a commit
that referenced
this pull request
Jun 2, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * DX-347: add (_include) template for models Keep most of the logic here so that it works (out of the box) with whatever lives in _data. This should be coupled with a symlink to dynamic/swagger. * DX-347: script to build models html pages * DX-347: add enums Also prevent adding examples pertaining to properties that have their own models page * DX-347: fix templates for models with [...] in name liquid templates were not rendering as they were, so I had to assign the name in a separate handlebar * DX-347: put finishing touches on model pages change node code to ES6 and use browsify --node now writing models/index.html. Navigation side bar only shows models pertaining to that model. ** see TODOs in commit ** restructuring swagger directory to have a consistent naming convention across all APIs * DX-347: grab product name from SWAGGER_CONFIG * DX-347: fix product name bug * small change to enable object properties to generate their own links in model docs * DX-347: rename swagger files and directory structure Directory structure was messy before. Relevant changes regarding this renaming were made for build script and config file * Property rendering now in seperate include, handle use of allOf in swagger defs, fix for object links * working definition builder * swagger file fixes * working model pages * minor naming change * unit tests for build-models helpers
benfjohnson
pushed a commit
that referenced
this pull request
Jun 5, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * DX-349: pull model names from $refs in swagger docs This is to just get it working. From here would be ideal to extract most of the new HTML out of endpoint.jsx and into a separate React component Reason for passing $refs in this way was because when dereferencing swagger docs, it gets rid of $ref value and theres no way of retrieving it for the anchor in the api-reference page. Therefore, we pass the docs twice, once dereferenced, and once not so that we can refer to these $ref tags. I could not find anything in Swagger docs that supported something like this out of the box. * DX-349: move markup into separate component and delete components no longer being used * DX-349: fix links for models Links to models from api-reference work now (if merged with DX-347) * DX-349: add markdown rendering * DX-349: extract apiDocumentationParam in separate component * table jsx fixes, model links now account for array req/res * Array[x] syntax not part of model anchor tag * DX-349: one URL instead of sandbox and prod
benfjohnson
pushed a commit
that referenced
this pull request
Jun 8, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * Finished DevDot portion of Ticket DX-276 * Finished up ticket 259 to go along with the completed 276 yesterday. DevDot Footer should be complete and working * Realligned GitHub Icon * single endpoints per page * Updated paths * methods index pages (tags in progress * Added models landing pages - including AvaTax tags * DX-343: add tests to assert navbar layout Assert nav bar links per endpoint * simplified api doc paths * DX-343: move helpers into file ignored by nightwatch * React app conditionally shows endpoint info or API description, depending on if apiEndpoints state is non-empty. Fixed links under APIs menu * fixes method index descriptions * DX-343: remove _data/api_tag_pages * DX-343: change navigation side bar Navigation side bar now using _data files generated upon build (inside swagger-to-api-doc.js) so that they are dynamic (unlike before) api_reference_navigation is still included in default and it includes the subnav template. The subnav template will recursively include itself if the `page` has a tag_name. This seems like (atm) a good indicator of whether method is under a subtag (only relevant to avatax rest v2, right now) * DX-343: make tests pass with new path structure Optimized tests by not calling maximizeWindow and end on every test, but only in before and after suite. Added flag to test-web so that it calls npm run build unless specified not to. Modified all tests to use proper url paths (changed in 342 ticket). Had to change a tad bit of logic in tests but nothing major * DX-343: compare apiName (also) as if there are no decimals excise products have decimals in them and liquid templates remove these when working with _data files, so we needed to remove them from apiName to do a comparison (strictly used for conditional) * removed defunct bootstrap affix/scrollspy code * DX-343: remove redundant 'index.html' in log * link fixes * DX-343: remove max-width for endpoint-summary * DX-343: change nav links to point to api homepage Was pointing to homepage/methods before
benfjohnson
pushed a commit
that referenced
this pull request
Jun 9, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * Links to related methods in models pages * unit tests for new helpers * link fix for single endpoint * fixed duplicate and broken method links in model pages
benfjohnson
pushed a commit
that referenced
this pull request
Jun 12, 2017
* Page Validate add on Project * [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * AvaTax BR API Update * Rolling back gems versions update. * fixes to work with latest structure changes
benfjohnson
pushed a commit
that referenced
this pull request
Jun 12, 2017
* [PORT-5641] Update host for Avalara for Communications REST API. (#230) (#1) * removed html comparison code * removed html-proofer gem dependency * fixes annoyingly-wide auth form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.