Fix/Skip tests and add php 8.2 and 8.3. by rodrigoaguilera · Pull Request #66 · beluga-php/docker-php · GitHub
Skip to content

Fix/Skip tests and add php 8.2 and 8.3.#66

Merged
flavioheleno merged 5 commits into
beluga-php:masterfrom
rodrigoaguilera:fix-test
Feb 19, 2024
Merged

Fix/Skip tests and add php 8.2 and 8.3.#66
flavioheleno merged 5 commits into
beluga-php:masterfrom
rodrigoaguilera:fix-test

Conversation

@rodrigoaguilera

@rodrigoaguilera rodrigoaguilera commented Feb 18, 2024

Copy link
Copy Markdown
Collaborator

The red cross showing next to the latest commits to master is annoying a gives the impression that the code is not useful at its current state.
What I did:

For this last one I tried for a while and what I get is a 101 http response with this headers

Upgrade: websocket                                                                                                                                               
Connection: Upgrade                                                   
Sec-WebSocket-Accept: Nq+SlyVfcOMLc9sY8KRmJVb3jBI=                                                                                                                            

Maybe we need a way to mark some endpoints as "Non-functional" (yet) or something similar.

For running the test locally I had to pull manually busybox:latest, the imageCreate endpoint won't pull it automatically. I'm not sure if this will fail in the CI.

@rodrigoaguilera

Copy link
Copy Markdown
Collaborator Author

@flavioheleno

Copy link
Copy Markdown
Member

awesome work @rodrigoaguilera !!! thank you very much for the effort!

Comment thread src/Context/ContextBuilder.php Outdated
Comment thread src/Docker.php Outdated
rodrigoaguilera and others added 2 commits February 19, 2024 13:51
Co-authored-by: Flávio Heleno <flaviohbatista@gmail.com>
Co-authored-by: Flávio Heleno <flaviohbatista@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@flavioheleno flavioheleno merged commit 82e23dc into beluga-php:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants