{{ message }}
Repository navigation
Use new_from_bytes instead of new_from_data, to avoid memory leaks - #4814
Merged
Merged
Conversation
cgkoutzigiannis
force-pushed
the
fix-4684
branch
from
October 19, 2026 20:15
c38817e to
c45654f
Compare
cgkoutzigiannis
marked this pull request as ready for review
October 19, 2026 20:16
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4684.
Changed the Image GTK implementation to use
new_from_bytes, instead ofnew_from_data, to avoid memory leaks.Based on the GTK docs for
new_from_data, it expects adestroyparameter, that is called to free the data allocated. So passingNone, doesn't free any memory.On the other hand,
new_from_bytesdoesn't take a parameter like that and frees memory on it's own.There is an ongoing discussion about this issue, since this is a bug with the Python bindings.
PR Checklist: