{{ message }}
Repository navigation
Conversation
Contributor
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable GTK4 message, stack trace, file, and folder dialogs. GTK 4.10 and newer use the asynchronous AlertDialog and FileDialog APIs; earlier GTK versions retain their compatible native dialog APIs. Stack traces use a modal window composed of native controls because AlertDialog cannot contain a scrolling trace.
Update the native probes to exercise dialog responses and file selection. GTK4 CI runs the dialog suites separately with external portals disabled so the probes can drive the in-process native chooser. Other suites use normal portal support, which WebKit needs for correct viewport allocation. The dialog helper waits for native completion before returning its result, preventing callbacks from leaking into the next test.
Refs #3069.
Validation: all 56 app-level and window-level dialog tests passed on GTK3, GTK4, and GTK4/libadwaita. Pre-commit, docs lint, and core/Travertino tests passed with 100% coverage.
PR Checklist:
Assisted-by: OpenAI Codex (GPT-6)