Add GTK4 support for Divider by kattni · Pull Request #4781 · beeware/toga · GitHub
Skip to content

Add GTK4 support for Divider - #4781

Open
kattni wants to merge 4 commits into
beeware:mainfrom
kattni:codex/gtk4-divider
Open

kattni wants to merge 4 commits into
beeware:mainfrom
kattni:codex/gtk4-divider

Conversation

@kattni

@kattni kattni commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Implement GTK4 Divider sizing for both orientations and enable its testbed coverage. The direction-change checks now verify visible thickness and wait for native geometry updates.

Refs #3069.

Validated with the Divider testbed suite on GTK3, GTK4, and GTK4 with libadwaita (4 passed each) on Ubuntu 26.04 ARM64. Pre-commit, docs lint, and core/Travertino tests passed with 100% coverage.

PR Checklist:

  • I will abide by the BeeWare Code of Conduct
  • I have read and have followed the CONTRIBUTING.md file
  • This PR was generated or assisted using an AI tool

Assisted-by: OpenAI Codex (GPT-6)

@johnzhou721 johnzhou721 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have Ubuntu 25.04 not 26.04 installed right now, so the testing environment may be different; I do not have the disk space to upgrade.

[EDIT—tested on Ubuntu 26.04 with same result]

But when I run the Divider example on this branch, the textboxes seem compressed in GTK4 + adwaita:
image
But not in GTK3:
image

This may or may not be a preexisting issue in which case we could file it separately, but if the fix is small perhaps it may be viable to stuff it in this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other platforms that may benefit from this check? I think WinForms might, especially when someone runs the testbed on HiDPI screens, because the Divider rehint code there may be easy to mess up if we use the wrong rounding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants