{{ message }}
This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Adds Tests for Various Lists Functions#291
Merged
Merged
Conversation
Owner
jeremylow
added a commit
that referenced
this pull request
Jan 31, 2016
Adds Tests for Various Lists Functions
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Like it says on the tin -- adds a bunch of tests for the List functions and refactors/fixes some of the old stuff that didn't get picked up before with py3 compatibility. There are a couple things of note:
GetListsListdon't require auser_idorscreen_nameparameter -- if neither is passed, then the data will be for the authenticated user.enf_type, which takes the name of the field, the type the field should be, and the value to convert and raises the appropriate errors if it cannot be done. So instead of:it's just:
The error raised is largely similar, it tells you the name of the field that was incorrect and the expected type. This isn't standard across the API since I wanted to keep this PR to just the List functions, but that's a todo I guess if it seems rational.
_IDList()which takes the list-y kwargs and figures out how the user is trying to identify a list (i.e., byidorslug + (user_id/screen_name).I think that's about it, but I've seen the word "list" about a million times these two days and I'm sure I missed something.
I also alphabetized the migration guide.