{{ message }}
Do not ask twice for project running ielm, term and vterm#1639
Merged
bbatsov merged 1 commit intobbatsov:masterfrom Jan 17, 2021
kinote:fix-asking-project-twice
Merged
Do not ask twice for project running ielm, term and vterm#1639bbatsov merged 1 commit intobbatsov:masterfrom kinote:fix-asking-project-twice
bbatsov merged 1 commit intobbatsov:masterfrom
kinote:fix-asking-project-twice
Conversation
Owner
Contributor
Author
|
Owner
|
Hmm, won't it be much better to just name the |
Do not ask twice for the project root when calling `projectile-run-ielm`, `projectile-run-term` or `projectile-run-vterm` from outside a projectile folder. These functions called `projectile-acquire-root` and then `projectile-generate-process-name` which also called `projectile-acquire-root`. This commit modifies `projectile-generate-process-name` to require a `project` parameter.
Contributor
Author
Yes, I think that makes more sense. I have updated the commit. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Do not ask twice for the project root when calling
projectile-run-ielm,projectile-run-termorprojectile-run-vtermfrom outside a projectile folder.
Use
projectile-with-default-dirat the beginning of those functionsto prevent calling
projectile-acquire-roottwice.When running one of those functions (e.g. projectile-run-vterm) from a folder outside a projectile root (e.g. my home folder) I was being ask twice in the minibuffer to provide a projectile project root. This was caused because projectile-acquire-root was being called twice without setting the default folder.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarningsThanks!