{{ message }}
Remove stale ndarray sorting warnings#603
Merged
t-muser merged 1 commit intobayesian-optimization:masterfrom Apr 1, 2026
Merged
Remove stale ndarray sorting warnings#603t-muser merged 1 commit intobayesian-optimization:masterfrom
t-muser merged 1 commit intobayesian-optimization:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 97.78% 98.34% +0.55%
==========================================
Files 10 10
Lines 1221 1210 -11
==========================================
- Hits 1194 1190 -4
+ Misses 27 20 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey, thanks for the PR! The warning is not stale (as in outdated), it alerts users that the behaviour has changed from older versions. However, I think it may still be time to remove it, it's been like this for ~9 months now. Will merge within a few days, unless there are objections :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the old ndarray sorting warning now that pbounds order is the canonical order. Add regression tests for register/probe with ndarray inputs.
Summary by CodeRabbit
Bug Fixes
Tests