fix(core): avoid reflecting vector tables during NFC migration by phernandez · Pull Request #1801 · basicmachines-co/basic-memory · GitHub
Skip to content

fix(core): avoid reflecting vector tables during NFC migration - #1801

Merged
phernandez merged 2 commits into
mainfrom
fix/nfc-migration-vector-tables
Oct 21, 2026
Merged

phernandez merged 2 commits into
mainfrom
fix/nfc-migration-vector-tables

Conversation

@phernandez

Copy link
Copy Markdown
Member

Why

On macOS, MCP startup failed during migration 0042 with OperationalError: no such module: vec0. The path migration reflected every table, including an existing search_vector_embeddings virtual table, on a connection without sqlite-vec loaded.

What Changed

Restrict column reflection to tables referenced by the migration's twin cleanup and path normalization statements.

Implementation Details

The migration already intentionally leaves embeddings to the orphan sweeper. Restricting reflection preserves that behavior without making path normalization depend on the optional vector extension. This repairs the existing migration so databases blocked before 0042 can upgrade.

Testing

  • Added a real sqlite-vec table with an embedding, then upgraded through a separate extension-free Alembic connection. The test reproduced the exact startup exception before the fix and passes afterward, verifying twin merging, accepted content preservation, and unchanged embeddings.
  • BASIC_MEMORY_ENV=test LOGFIRE_IGNORE_NO_CONFIG=1 uv run pytest -q tests/test_nfc_file_paths_migration.py tests/test_alembic_env.py tests/test_migration_graph.py --no-cov: 31 passed.
  • just fast-check: lint and typecheck passed; unrelated formatting was reverted.
  • just doctor: passed.
  • User confirmed the MCP connection works after restarting with the fix.

Risks / Follow-ups

No new migration or vector-table mutations. Databases that already applied 0042 do not rerun it.

Signed-off-by: phernandez <paul@basicmachines.co>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42ba588959

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_nfc_file_paths_migration.py
Signed-off-by: phernandez <paul@basicmachines.co>
@phernandez

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

@phernandez
phernandez merged commit c046b00 into main Oct 21, 2026
24 checks passed
@phernandez
phernandez deleted the fix/nfc-migration-vector-tables branch October 21, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant