{{ message }}
Repository navigation
fix(core): avoid reflecting vector tables during NFC migration - #1801
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42ba588959
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
Member
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
On macOS, MCP startup failed during migration 0042 with
OperationalError: no such module: vec0. The path migration reflected every table, including an existingsearch_vector_embeddingsvirtual table, on a connection without sqlite-vec loaded.What Changed
Restrict column reflection to tables referenced by the migration's twin cleanup and path normalization statements.
Implementation Details
The migration already intentionally leaves embeddings to the orphan sweeper. Restricting reflection preserves that behavior without making path normalization depend on the optional vector extension. This repairs the existing migration so databases blocked before 0042 can upgrade.
Testing
BASIC_MEMORY_ENV=test LOGFIRE_IGNORE_NO_CONFIG=1 uv run pytest -q tests/test_nfc_file_paths_migration.py tests/test_alembic_env.py tests/test_migration_graph.py --no-cov: 31 passed.just fast-check: lint and typecheck passed; unrelated formatting was reverted.just doctor: passed.Risks / Follow-ups
No new migration or vector-table mutations. Databases that already applied 0042 do not rerun it.