{{ message }}
fix: add entity_type parameter to write_note MCP tool - #145
Merged
Conversation
Member
Author
|
@claude lets add a test also that does not set an entity_type on the write_note tool call but sets one in the embedded note frontmatter. We want to make sure that is respected also. Example: This should have a type of "guilde" |
Contributor
|
Claude finished @phernandez's task —— View job Todo List
SummaryI've successfully added the requested test case
The test follows the same patterns as existing tests and includes proper assertions to verify the behavior. The changes have been committed to the PR branch. Test Details:
You can run |
Member
Author
|
@claude it looks like a test failed in the last job |
Contributor
- Add optional entity_type parameter with default "note" - Update function signature and docstring - Replace hardcoded entity_type="note" with parameter - Add comprehensive tests for different entity types - Ensure backward compatibility with default behavior Fixes #144 Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>
Add test_write_note_respects_frontmatter_entity_type to verify that when write_note is called without entity_type parameter, but the content includes frontmatter with a 'type' field, that type is respected instead of defaulting to 'note'. Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>
The test had a malformed YAML frontmatter delimiter (-- instead of ---) which was causing parsing failures. This fixes the test to use proper YAML frontmatter formatting. Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>
- Add frontmatter type extraction in EntityService.create_entity() and update_entity() - Override schema.entity_type when content frontmatter contains 'type' field - Fix lint error in alembic/env.py with noqa comment - Update test formatting for consistency - Ensures write_note respects both parameter and frontmatter entity_type values Fixes #144 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
phernandez
force-pushed
the
claude/issue-144-20250618_141005
branch
from
June 18, 2025 21:40
6d12c7b to
876fc70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #144
Summary
entity_typeparameter with default "note"entity_type="note"with parameterTest Plan
just testto verify all tests passjust lintandjust formatfor code qualityGenerated with Claude Code