feat: Add support for zoom by shmuelzon · Pull Request #15 · b451c/quickmd · GitHub
Skip to content

feat: Add support for zoom - #15

Merged
b451c merged 1 commit into
b451c:mainfrom
shmuelzon:add-support-for-zoom
Jul 27, 2026
Merged

feat: Add support for zoom#15
b451c merged 1 commit into
b451c:mainfrom
shmuelzon:add-support-for-zoom

Conversation

@shmuelzon

Copy link
Copy Markdown
Contributor

Add support for zoom in/out with the ⌘+ / ⌘- keyboard shortcut

@shmuelzon

Copy link
Copy Markdown
Contributor Author

@b451c
b451c merged commit ee2bce2 into b451c:main Jul 27, 2026
@b451c

b451c commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Merged - thank you for an excellent contribution!

This is one of the best-prepared PRs this repo has received. A few things that stood out during review:

  • fontScale threaded through the parser -> renderer pipeline with dual-scope attributes, exactly how the codebase needs it
  • per-tab routing via FocusedValue, so zooming one tab leaves the others alone
  • the renderedFontScale split that keeps headings and body text resizing in a single visual step
  • the Task.isCancelled guards, which also fix a pre-existing race where a superseded parse could land last
  • tests covering both style scopes and the zoom ladder clamping

I verified it hands-on (including plain Cmd+= without Shift, which correctly triggers Bigger) and ran the full test suite - all green. One tiny follow-up landed on main after the merge: the README shortcuts row now also mentions Cmd+0 / Actual Size.

This will ship in the next release. Thanks again!

@shmuelzon
shmuelzon deleted the add-support-for-zoom branch July 27, 2026 19:04
@shmuelzon

Copy link
Copy Markdown
Contributor Author

Glad you liked it, I have a couple more I'll push soon :)

@b451c

b451c commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants