feat(http): add support for proxy tunneling by Suall1969 · Pull Request #6465 · axios/axios · GitHub
Skip to content

feat(http): add support for proxy tunneling#6465

Open
Suall1969 wants to merge 1 commit into
axios:v1.xfrom
Suall1969:proxy-tunneling
Open

feat(http): add support for proxy tunneling#6465
Suall1969 wants to merge 1 commit into
axios:v1.xfrom
Suall1969:proxy-tunneling

Conversation

@Suall1969

@Suall1969 Suall1969 commented Jun 24, 2024

Copy link
Copy Markdown

This is the renewal of #5781 but rather than tunneling every HTTPS request which would be a breaking change, it introduces a new option to tunnel any request as desired.

Additionally, it fixes two issues with the existing proxy implementation: 1. When using an HTTPS proxy, the server name for the SNI TLS extension is incorrectly set to the target's, not the proxy's. 2. When the protocol is not set, it is incorrectly set to the target's, not http.
Admittedly, these changes should have been submitted in a different PR, but I was too lazy.

Oh and by the way, the documentation for the newly added option was ripped off from curl's manpage.

@zisuu

zisuu commented Aug 28, 2024

Copy link
Copy Markdown

@lockness-Ko

Copy link
Copy Markdown

@nidhishgajjar

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants