{{ message }}
fix(http): flush download progress before stream close#11040
Open
cyphercodes wants to merge 1 commit into
Open
fix(http): flush download progress before stream close#11040cyphercodes wants to merge 1 commit into
cyphercodes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes the Node HTTP adapter ordering where the final throttled
onDownloadProgresscallback could run after a streamed response emittedclose.Linked issue
Closes #6878
Changes
closelisteners.Checklist
🏄
Summary by cubic
Fixes Node HTTP adapter ordering so the final
onDownloadProgressfires before a streamed response emitsclose, avoiding late progress after consumers see the stream closed. Usesprocess.nextTickto schedule the final flush.Description
process.nextTick(fallback toutils.asap).asyncDecoratorto accept a scheduler and pass it from the HTTP adapter.close, which was confusing and incorrect.httpadapter behavior. Closes onDownloadProgress occurred after request solved #6878.Docs
onDownloadProgresswill not fire after streamclose. Update/docs/accordingly if relevant.Testing
closeand none fire after.Semantic version impact
Written for commit 50faae5. Summary will update on new commits.