{{ message }}
upgrade to 3.4 and fix interface changes#178
Closed
anqini wants to merge 2 commits into
Closed
Conversation
Author
|
Thanks for your update. That sounds good.
…________________________________
发件人: Chenyang Liu ***@***.***>
发送时间: Thursday, December 14, 2023 11:18:31 PM
收件人: awslabs/python-deequ ***@***.***>
抄送: Angelo Ni ***@***.***>; Author ***@***.***>
主题: Re: [awslabs/python-deequ] upgrade to 3.4 and fix interface changes (PR #178)
Note: Can we create a separate branch for this change to merge into? The changes are only compatible with scala-deequ version >=2.0.4 and not backward compatible. It will look fractional if we make it work universally since for the same class both new and old interfaces need to be invoked.
Currently we don't want to maintain separate branch for different version combinations. I agree we shouldn't make the code fractional to achieve the goal and we are working with a long-term plan with changes in Deequ core ideally. I'll share more details around early Jan.
Let's keep this PR open for more ideas.
―
Reply to this email directly, view it on GitHub<#178 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK7M4FCIMNLP76WRBDXMIJDYJMKEPAVCNFSM6AAAAABAUDCBQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGA2DCMZWG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hey @anqini @chenliu0831, is there a potential date to merge this PR? Looks like Deequ is already adding support to Spark 3.5 |
|
Closing this PR for now - we do not plan to maintain multiple branches and the changes mostly likely have to go to Deequ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#148
Forward compatibility issue for scala deequ version >=2.0.4.
Description of changes:
Update the invocation code according to the change of the Scala "deequ-2.0.6-spark-3.4" version interfaces
The interface changes include
Logic change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.