{{ message }}
More efficient packaging when NO_LIBC is specified.#8
Merged
Conversation
bmoffatt
reviewed
Dec 5, 2018
Collaborator
There was a problem hiding this comment.
A function author that also mutates the LD_LIBRARY_PATH environment variable might find this prepend surprising. Using /lib64/ld-linux-x86-64.so.2 --library-path ... should provide the same behavior, but still allow arbitrary LD_LIBRARY_PATH.
Contributor
Author
There was a problem hiding this comment.
The --library-path switch causes the paths defined in LD_LIBRARY_PATH to be ignored. See https://linux.die.net/man/8/ld-linux
I'll try switching it to append rather than prepend.
bmoffatt
approved these changes
Dec 5, 2018
bmoffatt
left a comment
bmoffatt
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. LMK if you think the LD_LIBRARY_PATH comment is relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.