{{ message }}
A few CMake improvements#68
Merged
Merged
Conversation
- Set the SONAME on the library to generate correct symlinks - Set visibility of inline functions to hidden (didn't use CMake since this library is linux only) - Use the built-in LTO detection mechanism instead of rolling my own
bmoffatt
approved these changes
Dec 3, 2019
marcomagdy
added a commit
that referenced
this pull request
Dec 3, 2019
- Set the SONAME on the library to generate correct symlinks - Set visibility of inline functions to hidden (didn't use CMake since this library is linux only) - Use the built-in LTO detection mechanism instead of rolling my own
marcomagdy
added a commit
that referenced
this pull request
Dec 3, 2019
This reverts commit b81d490.
bmoffatt
added a commit
that referenced
this pull request
Feb 25, 2020
Update README.md to reflect newer CMake dependency for in #68
marcomagdy
pushed a commit
that referenced
this pull request
Feb 25, 2020
Update README.md to reflect newer CMake dependency for in #68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1] I didn't use
CMAKE_CXX_VISIBILITY_PRESETandCMAKE_VISIBILITY_INLINES_HIDDENbecause IMO they obscure the compiler flags and this library only builds/runs on linux (and Windows has visibility hidden by default anyways). Let me know if you disagree, I don't have strong opinions about this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.