{{ message }}
fix(event_handler): sync middleware receives real response in async ASGI context#8089
Merged
leandrodamascena merged 2 commits intodevelopfrom Apr 6, 2026
Merged
fix(event_handler): sync middleware receives real response in async ASGI context#8089leandrodamascena merged 2 commits intodevelopfrom
leandrodamascena merged 2 commits intodevelopfrom
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/L
hjgraca
approved these changes
Apr 6, 2026
powertools-for-aws-oss-automation
Bot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Closes #7981
The fix runs sync middlewares in a separate thread. When the middleware calls
next(app), we intercept that call, resolve the async handler on the event loop, and pass the real response back to the thread. This way both request validation (pre-processing) and response validation (post-processing) see the actual data.Changes
_wrap_middleware_asyncinhttp_resolver.pyto use thread-based coordination between sync middlewares and async handlers@pytest.mark.skipfrom existing async validation testUser experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.