{{ message }}
refactor(parser): improves S3 models with examples and descriptions#7292
Merged
leandrodamascena merged 4 commits intoaws-powertools:developfrom Sep 2, 2025
Merged
Conversation
pull-request-size
Bot
added
the
size/L
ivica-k
commented
Sep 1, 2025
ivica-k
commented
Sep 1, 2025
ivica-k
force-pushed
the
refactor(parser)-s3-parser-fields
branch
4 times, most recently
from
a1bdb09 to
69fbe39
Compare
ivica-k
force-pushed
the
refactor(parser)-s3-parser-fields
branch
from
69fbe39 to
c8dbd4f
Compare
ivica-k
commented
Sep 1, 2025
leandrodamascena
requested changes
Sep 1, 2025
Contributor
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Hey @ivica-k thanks a lot for this PR! I just left some few comments to improve.
ivica-k
force-pushed
the
refactor(parser)-s3-parser-fields
branch
from
f42161f to
e62c5fd
Compare
ivica-k
force-pushed
the
refactor(parser)-s3-parser-fields
branch
from
e62c5fd to
65ab4b0
Compare
Contributor
Author
Lovely! I believe I addressed most of them, if not all, with the latest commit. |
leandrodamascena
approved these changes
Sep 2, 2025
Contributor
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this and addressing all the comments @ivica-k! APPROVED!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7120
Summary
Changes
Improves the S3 models with field descriptions and examples using Pydantic's
Field()functionality. This improvement provides better documentation and metadata for S3 event models.This change is fully backward compatible - no breaking changes to existing validation and serialization process.
User experience
Users will be able to see examples and description when serializing models.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.