{{ message }}
Merged
Conversation
ghost
requested review from
Mirrors the structure of the NodeJS ric with respect to github actions to run integ tests against all vendors. Issues with particular vendors won't be fixed in this PR to keep it short. Drops: python 3.7 in all but al1
ghost
commented
Jun 19, 2024
Comment on lines
+17
to
+56
Author
There was a problem hiding this comment.
This was pulled directly from the nodejs ric.
| .PHONY: test-integ | ||
| test-integ: setup-codebuild-agent | ||
| CODEBUILD_IMAGE_TAG=codebuild-agent tests/integration/codebuild-local/test_all.sh tests/integration/codebuild/. | ||
| CODEBUILD_IMAGE_TAG=codebuild-agent DISTRO="$(DISTRO)" tests/integration/codebuild-local/test_all.sh tests/integration/codebuild/. |
Author
There was a problem hiding this comment.
Pulled from nodejs ric, with some modification on the test path.
Comment on lines
+57
to
+58
Author
There was a problem hiding this comment.
Nit: this isn't necessary, will remove later.
briensea
approved these changes
Jun 19, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #153
Description of changes: makes the github PR workflow test against all OSes. Fixing integ tests is out of scope of this PR.
Drops 3.7 from all OSes except for AL1. AL1 will be removed completely in subsequent PR.
Target (OCI, Managed Runtime, both): N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.