{{ message }}
profiles: add with-group-merging feature#444
Merged
Merged
Conversation
pbrezina
force-pushed
the
with-group-merging
branch
5 times, most recently
from
6b18506 to
c087cd5
Compare
pbrezina
force-pushed
the
with-group-merging
branch
from
91e2536 to
8d57596
Compare
thalman
approved these changes
May 26, 2026
thalman
left a comment
thalman
left a comment
Member
There was a problem hiding this comment.
Code looks good, lets see what CI says.
This also makes group merging disabled by default. Group mergin is not required by majority of users, but it makes all group lookups to reach all providers (files, sss, systemd) which may cause performance issues under some conditions. It is better to let users who need it to enable it explicitly.
pbrezina
force-pushed
the
with-group-merging
branch
from
8d57596 to
0987096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes group merging disabled by default. Group mergin
is not required by majority of users, but it makes all group lookups
to reach all providers (files, sss, systemd) which may cause performance
issues under some conditions.
It is better to let users who need it to enable it explicitly.