Add new switchable-auth PAM stack#425
Conversation
pbrezina
force-pushed
the
switchable
branch
3 times, most recently
from
9d74b8d to
dd38554
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
Commits 2 and 3 mention Resolves: https://github.com/authselect/, but that's not correct. Apart from that I left some comments inline.
pbrezina
force-pushed
the
switchable
branch
2 times, most recently
from
1b7bbcd to
d3b836c
Compare
|
Please review and test this again. Thank you. |
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
LGTM! Thank you for putting this together.
There was a problem hiding this comment.
By default the dconf option enable-switchable-authentication is true.
We want it to be false in these profiles. Can it be explicitly set for these profiles?
I thought it was already set in an old version of this PR.
There was a problem hiding this comment.
It is for sssd 3444ffc#diff-0361612e3581da745de2cb12631d211904fff5e4b31c77dc5d99ae8cbcc22896R7
If I get it correctly, you want to set it to false on other profiles as it does not make sense to use it there, right?
There was a problem hiding this comment.
Done, nice catch. See latest update.
4 participants
No description provided.