{{ message }}
Repository navigation
Conversation
Contributor
Author
atomantic
approved these changes
Oct 21, 2026
atomantic
left a comment
atomantic
left a comment
Owner
There was a problem hiding this comment.
✅ Approved
The change correctly preserves booked sells with negative P&L by checking for booking markers, addressing a bug where historical fills were incorrectly overwritten. The included tests confirm the fix and regression.
Scope: accounting logic in src/regime-engine.js and test cases in tests/repair-historical-fill-annotations.test.js
Test evidence
- ✅
node --require ./tests/quiet-console.js --test tests/repair-historical-fill-annotations.test.js— All tests passed, including the new tests added to cover the fix.
Claims verified against the code
- src/regime-engine.js:833: The
isBookedvariable correctly identifies orders with booking markers.
jay23606
deleted the
pr-go/1394-boot-annotation-repair-overwrites-correc
branch
October 22, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Boot annotation repair could overwrite a correctly booked sell with negative P&L. The regression test previously covered only
bodyBookedSizeandbodyBooked; thebodyBookedmarker was untested.Change
Added a regression case for a negatively booked sell marked with
bodyBooked; the booking guard already preserves both markers.Testing
node --require ./tests/quiet-console.js --test tests/repair-historical-fill-annotations.test.js(expected failure with the booking guard removed; passed with the fix restored).Fixes #1394