{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Activate panes on any click, not just left click - #531
Merged
Conversation
darangi
force-pushed
the
wl-activate-pane-on-right-click
branch
from
November 6, 2020 13:17
19a76b7 to
45244a1
Compare
|
gh pr checkout 531 |
|
#568 # |
farisei77
approved these changes
Nov 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This allows focus to be transferred to the containing pane when right clicking on a tab. Helpful for atom/tree-view#1205 where if the Tree View was focused and someone tried renaming a tab by right clicking on it, the resulting dialog would be for the focused Tree View entry rather than the tab.
Also:
right-clickedclass. I plan to removerightClickedItemlater as well.event.whichtoevent.button.Alternate Designs
None.
Benefits
Focus will be transferred correctly.
Possible Drawbacks
I foresee none.
Applicable Issues
Refs atom/tree-view#1205
Refs atom/atom#16192
Refs atom/atom#21616