{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Conversation
This was referenced Oct 25, 2018
chfritz
force-pushed
the
tree-sitter-indentation-config
branch
2 times, most recently
from
January 12, 2019 04:02
99f24f3 to
0803731
Compare
…core See this PR in atom/atom: atom/atom#18321. Once the other PR is merged, this one then fixes atom#594. Updated: now without the need for a callback function as part of configuration
chfritz
force-pushed
the
tree-sitter-indentation-config
branch
from
January 21, 2019 04:41
0803731 to
d826f8f
Compare
Author
Author
|
The failing tests don't seem to be related to the changes in this PR. |
Contributor
|
@chfritz am working on resolving those errors. We should be good to go once resolved. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds the configuration needed for the new, tree-sitter based indentation logic. That new logic is implemented in this PR in atom/atom: atom/atom#18321.
Once that PR is merged, this one then fixes #594.
Alternate Designs
Since this only adds configuration, the real discussion about alternate design is in atom/atom#18321.
Benefits
Fixes several indentation issues that all arise from the fact that the previous regex based logic was inductive (i.e., only based on the previous line). This prevented the implementation of certain patterns that seem preferred by users (and seem more correct). See, e.g., atom/atom#6655 and others.
Possible Drawbacks
I'm not a huge fan of how I'm adding the functional configuration (precedingRowConditions) to the grammar. This clutters the namespace in that object a little (but not much). Other than that I don't see any downsides.-- this has now been improved to whereprecedingRowConditionsis no longer required.Applicable Issues
atom/atom#6655
#476
#560
to name a few.